[webkit-reviews] review granted: [Bug 97399] Allow setting a custom path to where the plug-in sandbox profiles are being kept : [Attachment 165270] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 97399: Allow setting a custom path to where the plug-in sandbox profiles
are being kept
https://bugs.webkit.org/show_bug.cgi?id=97399

Attachment 165270: Patch
https://bugs.webkit.org/attachment.cgi?id=165270&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=165270&action=review


> Source/WebKit2/UIProcess/Plugins/mac/PluginProcessProxyMac.mm:56
> +NSString * const PlugInSandboxProfileDirectoryPathKey =
@"PlugInSandboxProfileDirectoryPath";

I think the preference key should have a WebKit prefix.

> Source/WebKit2/UIProcess/Plugins/mac/PluginProcessProxyMac.mm:140
> +    NSString* sandboxProfileDirectoryPath = [[NSUserDefaults
standardUserDefaults] stringForKey:PlugInSandboxProfileDirectoryPathKey];
> +    if (sandboxProfileDirectoryPath)
> +	   parameters.sandboxProfileDirectoryPath =
String(sandboxProfileDirectoryPath);

Add a FIXME about disallowing this for app sandbox apps.