[webkit-reviews] review denied: [Bug 97267] [GTK] Use XDamage to simplify RedirectedXCompositeWindow : [Attachment 165174] Rebased on top of trunk

[bugzilla-daemon at webkit.org]

Alejandro G. Castro <alex at igalia.com> has denied Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 97267: [GTK] Use XDamage to simplify RedirectedXCompositeWindow
https://bugs.webkit.org/show_bug.cgi?id=97267

Attachment 165174: Rebased on top of trunk
https://bugs.webkit.org/attachment.cgi?id=165174&action=review

------- Additional Comments from Alejandro G. Castro <alex at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=165174&action=review


Great patch, added some comment. Also I found some issue that I could reproduce
reliably with the following steps:

1. Open and load MiniBrowser with: http://www.webkit.org/blog/386/3d-transforms

2. Go to www.google.com
3. Go back to the transforms webpage
4. Flip the card and wait for a moment, the webpage is replaced with grey
background.

After that even when reloading layered content and scrolling does not work any
more

I hope this helps.

> Source/WebCore/platform/gtk/RedirectedXCompositeWindow.cpp:93
> +    gdk_window_add_filter(0,
reinterpret_cast<GdkFilterFunc>(filterXDamageEvent), 0);

Should we remove the filter when we are not redirecting the window anymore to
avoid filtering events? Checking the API I also wonder if we could call this
function in the constructor and use the first parameter to filter with
m_window, maybe we can avoid using the hash, not sure if I'm missing some part.