[webkit-reviews] review granted: [Bug 97360] [Chromium][Mac] Remove loadFont from PlatformSupport : [Attachment 165184] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Mark Pilgrim (Google)
<pilgrim at chromium.org>'s request for review:
Bug 97360: [Chromium][Mac] Remove loadFont from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=97360

Attachment 165184: Patch
https://bugs.webkit.org/attachment.cgi?id=165184&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165184&action=review


> Source/WebCore/platform/chromium/PlatformSupport.h:94
>  #if OS(DARWIN)
> -    static bool loadFont(NSFont* srcFont, CGFontRef*, uint32_t* fontID);
>  #elif OS(UNIX)

Should we clean up this ifdef?

> Source/WebCore/platform/graphics/chromium/CrossProcessFontLoading.mm:126
> +    WebKit::WebSandboxSupport* ss =
WebKit::Platform::current()->sandboxSupport();

ss -> sandboxSupport (please use complete words in variable names)

> Source/WebCore/platform/graphics/chromium/CrossProcessFontLoading.mm:128
> +    if (!ss)
> +	   return 0;

Should we add an ASSERT_NOT_REACHED here like the old code had?