[webkit-reviews] review granted: [Bug 97372] Remove bogus assertions from ChildListMutationScope : [Attachment 165215] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 21 16:05:52 PDT 2012


Ryosuke Niwa <rniwa at webkit.org> has granted Adam Klein <adamk at chromium.org>'s
request for review:
Bug 97372: Remove bogus assertions from ChildListMutationScope
https://bugs.webkit.org/show_bug.cgi?id=97372

Attachment 165215: Patch
https://bugs.webkit.org/attachment.cgi?id=165215&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165215&action=review


> Source/WebCore/ChangeLog:11
> +	   Some asserts (and their accompanying comment) were trying to enforce

> +	   proper usage of ChildListMutationScope from WebCore, but in the
> +	   presence of MutationEvents they could fail due to arbitrary script
> +	   execution.

Does this invalidate the assumption stated above the declaration of
MutationAccumulator?
(I suppose that's the case given you're removing the comment).
In the presence of mutation events, can we end up delivering mutation records
before the outmost scope closes?

If so, are we violating the specification in this regard?


More information about the webkit-reviews mailing list