[webkit-reviews] review granted: [Bug 95161] WebProcess XPC services need have their environment set without disrupting all other XPC services : [Attachment 165186] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 95161: WebProcess XPC services need have their environment set without
disrupting all other XPC services
https://bugs.webkit.org/show_bug.cgi?id=95161

Attachment 165186: Patch
https://bugs.webkit.org/attachment.cgi?id=165186&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=165186&action=review


> Source/WebKit2/ChangeLog:14
> +	   the AppSandbox.

App Sandbox, unless you're talking about the MacOSX feature.

> Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm:127
> +    xpc_connection_set_event_handler(connection, ^(xpc_object_t event) { });


Please add a comment indicating why the block is empty here.

>
Source/WebKit2/WebProcessServiceForWebKitDevelopment/WebProcessServiceForWebKit
DevelopmentMain.mm:54
> +		   NSLog(@"re-exec");

:|