[webkit-reviews] review granted: [Bug 97277] [Chromium] Use OpenTypeVerticalData on Linux : [Attachment 165036] More rebaselines

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Kenichi Ishibashi
<bashi at chromium.org>'s request for review:
Bug 97277: [Chromium] Use OpenTypeVerticalData on Linux
https://bugs.webkit.org/show_bug.cgi?id=97277

Attachment 165036: More rebaselines
https://bugs.webkit.org/attachment.cgi?id=165036&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165036&action=review


Quotation marks look much better!

> Source/WebCore/platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:359
> +    uint32_t tag = (table >> 24) | ((table >> 8) & 0xff00) | ((table &
0xff00) << 8) | ((table & 0xff) << 24);

Should this be a SkFontTableTag?  I would move this into a function to help
document this code.  Something like, reverseByteOrder.

> Source/WebKit/chromium/features.gypi:205
> -	 ['OS=="win"', {
> +	 ['OS!="mac"', {

Do you mean to enable this on ios and android?	You could do 'OS=="win" or
use_x11==1'.