[webkit-reviews] review granted: [Bug 97242] Unexpected reftest passes are only reported when pixel testing is enabled : [Attachment 165062] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 21 11:19:47 PDT 2012


Dirk Pranke <dpranke at chromium.org> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 97242: Unexpected reftest passes are only reported when pixel testing is
enabled
https://bugs.webkit.org/show_bug.cgi?id=97242

Attachment 165062: Patch
https://bugs.webkit.org/attachment.cgi?id=165062&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165062&action=review


> Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:306
> +	   return TestResult(self._test_name, test_result.failures,
total_test_time + test_result.test_run_time, test_result.has_stderr, True)

nit: I'd say is_reftest=True here.


More information about the webkit-reviews mailing list