[webkit-reviews] review granted: [Bug 97330] [GTK] Add WebKitWebView:is-loading property to WebKit2 GTK+ API : [Attachment 165122] Patch

[bugzilla-daemon at webkit.org]

Xan Lopez <xan.lopez at gmail.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 97330: [GTK] Add WebKitWebView:is-loading property to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=97330

Attachment 165122: Patch
https://bugs.webkit.org/attachment.cgi?id=165122&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=165122&action=review


> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:1141
> +	   webkitWebViewUpdateURI(webView);

Maybe it's worth mentioning in the doc that when notify::is-loading is fired
you can already get the URI that will be loaded through the get_uri API, even
if notify::uri has not happened (seems to me that will be a common thing to
do).