[webkit-reviews] review granted: [Bug 97201] Add suggestionPicker to CalendarPicker : [Attachment 165118] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 97201: Add suggestionPicker to CalendarPicker
https://bugs.webkit.org/show_bug.cgi?id=97201

Attachment 165118: Patch
https://bugs.webkit.org/attachment.cgi?id=165118&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165118&action=review


> Source/WebCore/Resources/pagepopups/pickerCommon.js:86
> +    for (var node = selfNode; node && node !== selfNode.ownerDocument; node
= node.parentNode)
> +	   if (node.nodeType === Node.ELEMENT_NODE &&
node.classList.contains(className))
> +	       return node;

should wrap with { } because the content of 'for' has two lines.

> Source/WebCore/Resources/pagepopups/suggestionPicker.js:71
> +    var text = ".suggestion-list-entry:focus {\

should use ListEntryClass

> Source/WebCore/Resources/pagepopups/suggestionPicker.js:74
> +    text += ".suggestion-list-entry:focus .label { color: " +
this._config.suggestionHighlightTextColor + "; }";

ditto.