[webkit-reviews] review granted: [Bug 97224] [EFL] EventSender should mimic CTRL+o emacs shortcut : [Attachment 164933] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Christophe Dumez
<christophe.dumez at intel.com>'s request for review:
Bug 97224: [EFL] EventSender should mimic CTRL+o emacs shortcut
https://bugs.webkit.org/show_bug.cgi?id=97224

Attachment 164933: Patch
https://bugs.webkit.org/attachment.cgi?id=164933&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=164933&action=review


> Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp:100
> +    CString textUTF8 = text.utf8();

I think I would call it protectedText; or so to make it more clear why you are
doing this, so that no new refactoring will change it back to the former

> Tools/DumpRenderTree/efl/EventSender.cpp:536
> +    // Mimic the emacs ctrl-o binding by inserting a paragraph
> +    // separator and then putting the cursor back to its original
> +    // position. Allows us to pass emacs-ctrl-o.html

Please write why you are doing this (consistency with WK1 test results etc)