[webkit-reviews] review denied: [Bug 93372] Web Inspector: add memory used by memory allocator itself to NMI : [Attachment 164740] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 21 03:10:39 PDT 2012


Pavel Feldman <pfeldman at chromium.org> has denied Alexei Filippov
<alph at chromium.org>'s request for review:
Bug 93372: Web Inspector: add memory used by memory allocator itself to NMI
https://bugs.webkit.org/show_bug.cgi?id=93372

Attachment 164740: Patch
https://bugs.webkit.org/attachment.cgi?id=164740&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=164740&action=review


> Source/WebCore/platform/chromium/MemoryUsageSupportChromium.cpp:78
> +    if (base::allocator::GetProperty("generic.heap_size", &heapSize)

I don't see how this resolves concerns raised my jamesr at .


More information about the webkit-reviews mailing list