[webkit-reviews] review denied: [Bug 96103] Web Inspector: show time frame were blocked by flushing of previous frames in Timeline : [Attachment 162771] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 96103: Web Inspector: show time frame were blocked by flushing of previous
frames in Timeline
https://bugs.webkit.org/show_bug.cgi?id=96103

Attachment 162771: Patch
https://bugs.webkit.org/attachment.cgi?id=162771&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=162771&action=review


> Source/WebCore/inspector/InspectorTimelineAgent.cpp:217
> +    if (m_hadDelayFrameRecord)

Why is it safe to drop subsequent delays?

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:573
> +	   presentationModel._delayFrameRecord = null;

This makes code much more complex. Why exactly do we need this?