[webkit-reviews] review denied: [Bug 95114] Web Inspector: Refactor SourceFrame to delegate highlightLine() to _textEditor : [Attachment 162337] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied johnjbarton
<johnjbarton at chromium.org>'s request for review:
Bug 95114: Web Inspector: Refactor SourceFrame to delegate highlightLine() to
_textEditor
https://bugs.webkit.org/show_bug.cgi?id=95114

Attachment 162337: Patch
https://bugs.webkit.org/attachment.cgi?id=162337&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=162337&action=review


> Source/WebCore/inspector/front-end/SourceFrame.js:173
> +	   return this._textEditor.canHighlightLine();

SourceFrame should be always able to highlight the line.

> Source/WebCore/inspector/front-end/SourceFrame.js:-193
> -		   delete this._lineToHighlight

What about the case when we get request for the line highlight before the
content has loaded into the text editor? Like stopping on a breakpoint that
leads to the SourceFrame being opened.