[webkit-reviews] review denied: [Bug 95341] Web Inspector: The JS code injected by worker inspector shouldn't be evaluated through JSMainThreadExecState : [Attachment 161213] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Peter Wang
<peter.wang at torchmobile.com.cn>'s request for review:
Bug 95341: Web Inspector:  The JS code injected by worker inspector shouldn't
be evaluated through JSMainThreadExecState
https://bugs.webkit.org/show_bug.cgi?id=95341

Attachment 161213: Patch
https://bugs.webkit.org/attachment.cgi?id=161213&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=161213&action=review


> Source/WebCore/ChangeLog:10
> +	   No new test case.

Can this be tested?

> Source/WebCore/bindings/js/ScriptFunctionCall.cpp:40
> +#ifndef NDEBUG

Do we have debug-related behavior here?

> Source/WebCore/inspector/InjectedScriptManager.h:71
> +    explicit InjectedScriptManager(InspectedStateAccessCheck, bool = false);


bool isForWorker = false