[webkit-reviews] review denied: [Bug 97300] [Forms] DateTimeEditElement::layout() should take date time format as a parameter : [Attachment 165059] Patch 1

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied yosin at chromium.org's request for
review:
Bug 97300: [Forms] DateTimeEditElement::layout() should take date time format
as a parameter
https://bugs.webkit.org/show_bug.cgi?id=97300

Attachment 165059: Patch 1
https://bugs.webkit.org/attachment.cgi?id=165059&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165059&action=review


> Source/WebCore/html/TimeInputType.cpp:311
> +    bool const hasValue = parseToDateComponents(element()->value(), &date);

We usually put "const" followed by a type name.
  const bool hasValue ...

> Source/WebCore/html/shadow/DateTimeEditElement.cpp:410
> +bool DateTimeEditElement::shouldHaveSecondField(const LayoutParameters&
layoutParameters)

This should be a member of LayoutParameters.