[webkit-reviews] review granted: [Bug 97220] [Qt] Unify the PageViewportController<->Client interface regarding positions : [Attachment 164930] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Jocelyn Turcotte
<jocelyn.turcotte at digia.com>'s request for review:
Bug 97220: [Qt] Unify the PageViewportController<->Client interface regarding
positions
https://bugs.webkit.org/show_bug.cgi?id=97220

Attachment 164930: Patch
https://bugs.webkit.org/attachment.cgi?id=164930&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=164930&action=review


I hope this is well tested :-)

> Source/WebKit2/UIProcess/PageViewportController.cpp:127
> +    FloatRect endPosRange =
positionRangeForViewportAtScale(m_effectiveScale);

hmm your other patch removed this