[webkit-reviews] review granted: [Bug 96974] [EFL][WK2] Add setting to toggle developer extensions : [Attachment 165003] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Seokju Kwon
<seokju.kwon at samsung.com>'s request for review:
Bug 96974: [EFL][WK2] Add setting to toggle developer extensions
https://bugs.webkit.org/show_bug.cgi?id=96974

Attachment 165003: Patch
https://bugs.webkit.org/attachment.cgi?id=165003&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165003&action=review


> Source/WebKit2/UIProcess/API/efl/ewk_settings.h:123
> + * @return @c EINA_TRUE on success or @EINA_FALSE on failure
> + */
> +EAPI Eina_Bool ewk_settings_developer_extras_enabled_set(Ewk_Settings
*settings, Eina_Bool enable);

I know this is consistent with the rest of the api, but it actually only
retursn false when the API is *used wrongly*. A crash or assert would even be
better. I think we should change all these _set apis to not return anything