[webkit-reviews] review granted: [Bug 97278] [WK2] Add basic testing support for Geolocation : [Attachment 165031] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 20 23:04:07 PDT 2012


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 97278: [WK2] Add basic testing support for Geolocation
https://bugs.webkit.org/show_bug.cgi?id=97278

Attachment 165031: Patch
https://bugs.webkit.org/attachment.cgi?id=165031&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165031&action=review


LGTM

> Tools/ChangeLog:10
> +
> +

nit: double newline

> Tools/WebKitTestRunner/TestController.cpp:393
> +	   decidePolicyForGeolocationPermissionRequest, //
decidePolicyForGeolocationPermissionRequest

I dont think that commetn adds any value anymore


More information about the webkit-reviews mailing list