[webkit-reviews] review granted: [Bug 97286] Chromium mac cannot display AppleColorEmoji : [Attachment 165038] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Kenichi Ishibashi
<bashi at chromium.org>'s request for review:
Bug 97286: Chromium mac cannot display AppleColorEmoji
https://bugs.webkit.org/show_bug.cgi?id=97286

Attachment 165038: Patch
https://bugs.webkit.org/attachment.cgi?id=165038&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165038&action=review


> Source/WebCore/platform/graphics/mac/FontCacheMac.mm:122
> +#if PLATFORM(CHROMIUM) && OS(DARWIN)
> +    // Chromium can't render AppleColorEmoji.
> +    if ([[substituteFont familyName] isEqual:@"Apple Color Emoji"])
> +	   return 0;
> +#endif

nit: I think OS(DARWIN) is not needed.

FYI:
Using PLATFORM() macro is not preferable in general.
Ideally, we had better have WTF_USE_NO_APPLE_COLOR_EMOJI flag, and enable it
for Chromium in WebCore/config.h.

Using PLATFORM() is acceptable in this case because it's temporarily.