[webkit-reviews] review granted: [Bug 97225] make Skip, WontFix be the only expectations on a line : [Attachment 165014] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 97225: make Skip, WontFix be the only expectations on a line
https://bugs.webkit.org/show_bug.cgi?id=97225

Attachment 165014: Patch
https://bugs.webkit.org/attachment.cgi?id=165014&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165014&action=review


> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:442
> +	   return self.warnings and self.warnings != ['Test lacks BUG
modifier.']

This is a bit too hacky I think. Could we at least move the string to a shared
constant that both locations use?