[webkit-reviews] review granted: [Bug 97025] Text Autosizing: Cluster text at flow roots, for consistency and to avoid autosizing headers/footers. : [Attachment 164997] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted John Mellor
<johnme at chromium.org>'s request for review:
Bug 97025: Text Autosizing: Cluster text at flow roots, for consistency and to
avoid autosizing headers/footers.
https://bugs.webkit.org/show_bug.cgi?id=97025

Attachment 164997: Patch
https://bugs.webkit.org/attachment.cgi?id=164997&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=164997&action=review


r=me, please update the ChangeLog before landing.

> Source/WebCore/ChangeLog:40
> +	       - Store windowSize and minLayoutSize in member variables rather
than
> +		 passing them as parameters.

That was changed.

> Source/WebCore/ChangeLog:105
> +	       - Added m_windowSize and m_minLayoutSize members to cache the
> +		 values computed in processSubtree (hence avoid passing them as

> +		 parameters to every call to processCluster/processContainer).

Ditto.