[webkit-reviews] review denied: [Bug 97242] Unexpected reftest passes are only reported when pixel testing is enabled : [Attachment 164961] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 20 14:07:05 PDT 2012


Dirk Pranke <dpranke at chromium.org> has denied Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 97242: Unexpected reftest passes are only reported when pixel testing is
enabled
https://bugs.webkit.org/show_bug.cgi?id=97242

Attachment 164961: Patch
https://bugs.webkit.org/attachment.cgi?id=164961&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
the change is basically fine, but can you make is_reftest a field on the
TestResult object rather than passing a separate parameter across?


More information about the webkit-reviews mailing list