[webkit-reviews] review granted: [Bug 96765] Implement the "Content-Security-Policy" header. : [Attachment 164884] Better enum names.

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Mike West <mkwst at chromium.org>'s
request for review:
Bug 96765: Implement the "Content-Security-Policy" header.
https://bugs.webkit.org/show_bug.cgi?id=96765

Attachment 164884: Better enum names.
https://bugs.webkit.org/attachment.cgi?id=164884&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=164884&action=review


> Source/WebCore/page/ContentSecurityPolicy.cpp:732
> -    explicit CSPDirectiveList(ContentSecurityPolicy*);
> +    explicit CSPDirectiveList(ContentSecurityPolicy*,
ContentSecurityPolicy::HeaderType);

"explicit" no longer needed

> Source/WebCore/page/ContentSecurityPolicy.cpp:1233
> -    else if (equalIgnoringCase(name, formAction))
> +    else if (equalIgnoringCase(name, formAction) && m_experimental)

I would check m_experimental first since it's faster.

> Source/WebKit/chromium/src/AssertMatchingEnums.cpp:4
> - * Redistribution and use in source and binary forms, with or without
> - * modification, are permitted provided that the following conditions are
> - * met:
> - *
> - *	  * Redistributions of source code must retain the above copyright
> - * notice, this list of conditions and the following disclaimer.
> - *	  * Redistributions in binary form must reproduce the above
> +m

License corruption?