[webkit-reviews] review denied: [Bug 97176] Add setUsesEncodingDetector function in InternalSettings. : [Attachment 164890] patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Kangil Han
<kangil.han at samsung.com>'s request for review:
Bug 97176: Add setUsesEncodingDetector function in InternalSettings.
https://bugs.webkit.org/show_bug.cgi?id=97176

Attachment 164890: patch
https://bugs.webkit.org/attachment.cgi?id=164890&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=164890&action=review


> Source/WebCore/testing/InternalSettings.idl:85
> +	   void setUsesEncodingDetector(in boolean enabled)
raises(DOMException);

"Internal settings set uses encoding detector" is unnecessarily bad grammar.
Please improve it.

The function never raises exceptions, so it should not be marked as such, even
if other functions in this file are.