[webkit-reviews] review requested: [Bug 95479] [CSS Exclusions] shape-inside line segment layout should be based on line position and height : [Attachment 164945] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 20 10:54:54 PDT 2012


Bear Travis <betravis at adobe.com> has asked  for review:
Bug 95479: [CSS Exclusions] shape-inside line segment layout should be based on
line position and height
https://bugs.webkit.org/show_bug.cgi?id=95479

Attachment 164945: Updated patch
https://bugs.webkit.org/attachment.cgi?id=164945&action=review

------- Additional Comments from Bear Travis <betravis at adobe.com>
Incorporating Hans' feedback, and fixing the test failure.
Line positions within a shape are no longer guaranteed to have line segments.
Removing the appropriate comments and tests.
Changing lineState tests to use boolean inlines, right now just
lineOverlapsShapeBounds.
Removing lineState.
Going to leave the pixel snapping logicalLeft/Right code in place and file a
bug for it (bug 97236).


More information about the webkit-reviews mailing list