[webkit-reviews] review denied: [Bug 97228] [MathML] Increase visual space around fraction parts, italic variables, and operators : [Attachment 164937] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Dave Barton <dbarton at mathscribe.com>'s
request for review:
Bug 97228: [MathML] Increase visual space around fraction parts, italic
variables, and operators
https://bugs.webkit.org/show_bug.cgi?id=97228

Attachment 164937: Patch
https://bugs.webkit.org/attachment.cgi?id=164937&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=164937&action=review


Otherwise looks fine to me.  I don't know if you want your MathML peeps to sign
off or not.  I'm not much help in evaluating the beauty of the Math.

I'm ready to r+ with teh enum.

> Source/WebCore/rendering/mathml/RenderMathMLFenced.h:44
> +    RenderMathMLOperator* createMathMLOperator(UChar, bool isFence);

Much better to use an enum here.  Makes the callsites clearer.

enum OperatorType {
    FenceOperator,
    NormalOperator?
}

createMathMLOperator can even have OperatorType = NormalOperator so most
callsites don't have to pass anything if you like.