[webkit-reviews] review granted: [Bug 97094] [EFL][WK2] Same page navigation does not update view URI : [Attachment 164845] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Christophe Dumez
<christophe.dumez at intel.com>'s request for review:
Bug 97094: [EFL][WK2] Same page navigation does not update view URI
https://bugs.webkit.org/show_bug.cgi?id=97094

Attachment 164845: Patch
https://bugs.webkit.org/attachment.cgi?id=164845&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=164845&action=review


This looks so much better

> Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:174

> +    if (strcmp(ewk_view_title_get(webView), data->expectedValue().data()))

why not just value() ?