[webkit-reviews] review denied: [Bug 97166] REGRESSION(r127727): Can't navigate between months with arrow keys in calendar picker : [Attachment 164842] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 97166: REGRESSION(r127727): Can't navigate between months with arrow keys
in calendar picker
https://bugs.webkit.org/show_bug.cgi?id=97166

Attachment 164842: Patch
https://bugs.webkit.org/attachment.cgi?id=164842&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=164842&action=review


>>> LayoutTests/fast/forms/date/calendar-picker-key-operations.html:33
>>> +	 shouldBe('selectedDate()', '"2000-01-02"');
>> 
>> I don't understand this.
>> 1999-12-26 + upArrow isn't 1999-12-19?
> 
> This is moving from 1999-12-26  in the top row of the January calendar to
2000-01-02 in the last row of the December calendar.

Oh, I see.

We had better check YearMonthController.year() and month() values in the test,
or add comments in the test.