[webkit-reviews] review granted: [Bug 97162] OSR exit sometimes neglects to create the arguments object : [Attachment 164828] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Geoffrey Garen <ggaren at apple.com>'s
request for review:
Bug 97162: OSR exit sometimes neglects to create the arguments object
https://bugs.webkit.org/show_bug.cgi?id=97162

Attachment 164828: Patch
https://bugs.webkit.org/attachment.cgi?id=164828&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=164828&action=review


Your call on the hash traits thingy.  I think they might be useful in other
cases, too, so having them in the DFG, and particularly in the header of one
phase of the DFG, seems awkward.  But I can't bring myself to care too much.

> Source/JavaScriptCore/dfg/DFGArgumentsSimplificationPhase.h:44
> +template<typename T>
> +struct NullableHashTraits : public HashTraits<T> {
> +    static const bool emptyValueIsZero = false;
> +    static T emptyValue() { return reinterpret_cast<T>(1); }
> +};
> +

It's not a big deal but it would be super fabulous if this was in HashTraits.h.