[webkit-reviews] review granted: [Bug 97152] update flakiness dashboard after cutover to new test expectations syntax : [Attachment 164813] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 19 18:18:06 PDT 2012


Ojan Vafai <ojan at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 97152: update flakiness dashboard after cutover to new test expectations
syntax
https://bugs.webkit.org/show_bug.cgi?id=97152

Attachment 164813: Patch
https://bugs.webkit.org/attachment.cgi?id=164813&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=164813&action=review


Don't you also need to modify processExpectations? I guess that can be a
separate patch.

> Tools/TestResultServer/static-dashboards/flakiness_dashboard.js:984
> +    // FIXME: do we still need the INTERNAL_BUG replacements? They're
> +    // broken temporarily.

No. You can just delete this whole function.


More information about the webkit-reviews mailing list