[webkit-reviews] review canceled: [Bug 96567] [V8] ScriptController::compileAndRunScript() can crash : [Attachment 164640] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 19 17:41:23 PDT 2012


Kentaro Hara <haraken at chromium.org> has canceled  review:
Bug 96567: [V8] ScriptController::compileAndRunScript() can crash
https://bugs.webkit.org/show_bug.cgi?id=96567

Attachment 164640: Patch
https://bugs.webkit.org/attachment.cgi?id=164640&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=164640&action=review


>> Source/WebCore/bindings/v8/ScriptSourceCode.cpp:53
>> +	    return nullptr;
> 
> There's no reason to call get() here.  OwnPtr has a bool operator.

Fixed. Thanks.


More information about the webkit-reviews mailing list