[webkit-reviews] review requested: [Bug 97139] nrwt: convert chromium TestExpectations to the new syntax : [Attachment 164790] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has asked  for review:
Bug 97139: nrwt: convert chromium TestExpectations to the new syntax
https://bugs.webkit.org/show_bug.cgi?id=97139

Attachment 164790: Patch
https://bugs.webkit.org/attachment.cgi?id=164790&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=164790&action=review


> Tools/Scripts/convert-test-expectations:7
> +

For thoroughness sake, maybe put a FIXME to delete this file once all the
conversions are done?

> LayoutTests/platform/chromium/TestExpectations:154
> +webkit.org/b/68610 fast/dom/MicroData

Now that I see this in practice, I think it's pretty confusing to not have [
Skip ] indicating that the test is skipped. WDYT?

> LayoutTests/platform/chromium/TestExpectations:157
> +crbug.com/103939 http/tests/appcache/wrong-content-type.html [ Failure Skip
]

Sorry if my memory is foggy here. Didn't we decide to now allow an expectation
type if the test is skipped?

> LayoutTests/platform/chromium/TestExpectations:229
> +dom/xhtml/level2/html/HTMLDocument17.xhtml [ Failure Skip WontFix ]

In the end we want this to just be [ WontFix ], right? Will we just need to do
another pass over the file once we support WontFix without Skip or other listed
expectations?