[webkit-reviews] review denied: [Bug 86914] Enable webaudio/ tests on DRT/Mac. : [Attachment 146400] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 86914: Enable webaudio/ tests on DRT/Mac.
https://bugs.webkit.org/show_bug.cgi?id=86914

Attachment 146400: Patch
https://bugs.webkit.org/attachment.cgi?id=146400&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=146400&action=review


>> Source/WebKit/mac/WebCoreSupport/DumpRenderTreeSupportMac.cpp:26
>> +#include "DumpRenderTreeSupportMac.h"
> 
> Found header this file implements before WebCore config.h. Should be:
config.h, primary header, blank line, and then alphabetically sorted. 
[build/include_order] [4]

DumpRenderTreeSupport is a terrible name for this, a) because DumpRenderTree
itself is a terrible name, and b) because presumably this would also be used
from WebKitTestRunner.

Why can't this be done via window.internals?