[webkit-reviews] review denied: [Bug 97095] MediaStream API: Extend UserMediaRequest with a callingFrame method : [Attachment 164717] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 19 11:43:20 PDT 2012
Adam Barth <abarth at webkit.org> has denied Tommy Widenflycht
<tommyw at google.com>'s request for review:
Bug 97095: MediaStream API: Extend UserMediaRequest with a callingFrame method
https://bugs.webkit.org/show_bug.cgi?id=97095
Attachment 164717: Patch
https://bugs.webkit.org/attachment.cgi?id=164717&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
This is fine, but it should return the associated Document rather than the
Frame. DOM-related objects are associated with Documents (the "D" in DOM
stands for Document). View-related objects are associated with Frames.
WebDocument has a frame() function, so the embedder can find the Frame if it
needs that for its own purposes.
More information about the webkit-reviews
mailing list