[webkit-reviews] review granted: [Bug 97093] [Chromium] Improve glyph positioning of HarfBuzzShaper : [Attachment 164705] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Kenichi Ishibashi
<bashi at chromium.org>'s request for review:
Bug 97093: [Chromium] Improve glyph positioning of HarfBuzzShaper
https://bugs.webkit.org/show_bug.cgi?id=97093

Attachment 164705: Patch
https://bugs.webkit.org/attachment.cgi?id=164705&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=164705&action=review


FWIW, if you uploaded before and after png results for the tests that change as
a separate attachment to the bug, it would help me understand the change.

> Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:319
> +    // HarfBuzz returns the shaping result in visual order. We need not to
flip for RTL

Nit: Missing period at the end of the sentence.