[webkit-reviews] review denied: [Bug 96282] [Chromium] remove getFontFamilyForCharacters from PlatformSupport : [Attachment 163152] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 19 10:26:28 PDT 2012


Adam Barth <abarth at webkit.org> has denied Mark Pilgrim (Google)
<pilgrim at chromium.org>'s request for review:
Bug 96282: [Chromium] remove getFontFamilyForCharacters from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=96282

Attachment 163152: Patch
https://bugs.webkit.org/attachment.cgi?id=163152&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=163152&action=review


> Source/WebCore/platform/chromium/PlatformSupport.h:105
> -#elif OS(UNIX)
> -    struct FontFamily {
> -	   String name;
> -	   bool isBold;
> -	   bool isItalic;
> -    };
> -    static void getFontFamilyForCharacters(const UChar*, size_t
numCharacters, const char* preferredLocale, FontFamily*);
>  #endif

Rather than inlining this function, it looks like we might need to add it to
FontFamily.h and then have
WebCore/platform/graphics/chromium/FontFamilyChromiumLinux.cpp and a
WebCore/platform/graphics/blackberry/FontFamilyBlackberry.cpp implementation.


More information about the webkit-reviews mailing list