[webkit-reviews] review granted: [Bug 97011] Implement 'mask-type' for <mask> : [Attachment 164549] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Dirk Schulze <krit at webkit.org>'s
request for review:
Bug 97011: Implement 'mask-type' for <mask>
https://bugs.webkit.org/show_bug.cgi?id=97011

Attachment 164549: Patch
https://bugs.webkit.org/attachment.cgi?id=164549&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=164549&action=review


Looks good!
r=me with the below mistake fixed. (Perhaps we could even add a test for it?)

> Source/WebCore/css/SVGCSSComputedStyleDeclaration.cpp:197
>	   case CSSPropertyMarker:
> +	   case CSSPropertyMaskType:
> +	       return CSSPrimitiveValue::create(svgStyle->maskType());

Beep beep! Mistake here: We shouldn't return the mask type for
CSSPropertyMarker.