[webkit-reviews] review denied: [Bug 97099] [BlackBerry] add function playerId() in class PageClientBlackBerry : [Attachment 164722] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 19 07:16:49 PDT 2012


Yong Li <yoli at rim.com> has denied Jonathan Dong
<jonathan.dong at torchmobile.com.cn>'s request for review:
Bug 97099: [BlackBerry] add function playerId() in class PageClientBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=97099

Attachment 164722: Patch
https://bugs.webkit.org/attachment.cgi?id=164722&action=review

------- Additional Comments from Yong Li <yoli at rim.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=164722&action=review


otherwise LGTM

> Source/WebKit/blackberry/Api/WebPage_p.h:182
> +    virtual int playerId() const;

according to WebKit style or existing code, we should name it playerID() rather
than playerId.


More information about the webkit-reviews mailing list