[webkit-reviews] review denied: [Bug 97065] Web Inspector: Source Mapping doesn't work when inspector is in remote-mode : [Attachment 164691] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 19 01:57:16 PDT 2012
Vsevolod Vlasov <vsevik at chromium.org> has denied Peter Wang
<peter.wang at torchmobile.com.cn>'s request for review:
Bug 97065: Web Inspector: Source Mapping doesn't work when inspector is in
remote-mode
https://bugs.webkit.org/show_bug.cgi?id=97065
Attachment 164691: Patch
https://bugs.webkit.org/attachment.cgi?id=164691&action=review
------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=164691&action=review
> Source/WebCore/inspector/front-end/DebuggerScriptMapping.js:57
> + if (!mapping._asyncLoadSource)
I don't think this fixes the problem I mentioned.
We should always have a mapping set for script which will correctly transfrom
any raw location to ui location at any moment.
More information about the webkit-reviews
mailing list