[webkit-reviews] review denied: [Bug 97065] Web Inspector: Source Mapping doesn't work when inspector is in remote-mode : [Attachment 164651] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has denied Peter Wang
<peter.wang at torchmobile.com.cn>'s request for review:
Bug 97065: Web Inspector: Source Mapping doesn't work when inspector is in
remote-mode
https://bugs.webkit.org/show_bug.cgi?id=97065

Attachment 164651: Patch
https://bugs.webkit.org/attachment.cgi?id=164651&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=164651&action=review


> Source/WebCore/inspector/front-end/CompilerScriptMapping.js:95
> +	       sourceMap = this.loadSourceMapForScript(script);

You should add return here for this patch to work.
This means the script won't have source mapping until source map is loaded,
which means stopping on breakpoint at this point would break things.