[webkit-reviews] review granted: [Bug 96352] [Chromium] Fix crash in WebFrameImpl::loadHistoryItem : [Attachment 164664] Patch 2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 18 22:59:03 PDT 2012


Adam Barth <abarth at webkit.org> has granted Kent Tamura <tkent at chromium.org>'s
request for review:
Bug 96352: [Chromium] Fix crash in WebFrameImpl::loadHistoryItem
https://bugs.webkit.org/show_bug.cgi?id=96352

Attachment 164664: Patch 2
https://bugs.webkit.org/attachment.cgi?id=164664&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Ok. This patch seems better than the previous one.  It's aways worrying when we
ASSERT one thing and then handle the case where the ASSERT fails.  Obviously,
I'd much prefer if we had a regression test for this issue.  Perhaps we can
investigate when currentItem() returns 0 and build a test case out of that? 
I'm going to mark this patch r+, but please consider working on a test case.


More information about the webkit-reviews mailing list