[webkit-reviews] review denied: [Bug 97067] [Chromium] SkiaGetGlyphWidthAndExtents() should invert y-axis : [Attachment 164658] Patch

[bugzilla-daemon at webkit.org]

Yuta Kitamura <yutak at chromium.org> has denied Kenichi Ishibashi
<bashi at chromium.org>'s request for review:
Bug 97067: [Chromium] SkiaGetGlyphWidthAndExtents() should invert y-axis
https://bugs.webkit.org/show_bug.cgi?id=97067

Attachment 164658: Patch
https://bugs.webkit.org/attachment.cgi?id=164658&action=review

------- Additional Comments from Yuta Kitamura <yutak at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=164658&action=review


Code change looks fine. r- for lack of comments for non-obvious code.

> Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzNGFaceSkia.cpp:72
> +	   extents->y_bearing = SkiaScalarToHarfbuzzPosition(-skBounds.fTop);

I would like some comments explaining these nagations. Looks hard to
understand.