[webkit-reviews] review requested: [Bug 17427] Line breaking opportunities at the end of a text node are missed : [Attachment 164653] Proposed patch v2

[bugzilla-daemon at webkit.org]

Alex Henrie <alexhenrie24 at gmail.com> has asked	for review:
Bug 17427: Line breaking opportunities at the end of a text node are missed
https://bugs.webkit.org/show_bug.cgi?id=17427

Attachment 164653: Proposed patch v2
https://bugs.webkit.org/attachment.cgi?id=164653&action=review

------- Additional Comments from Alex Henrie <alexhenrie24 at gmail.com>
Okay, here is version 2 of the patch (the segfault seems to have been fixed in
the latest SVN revision). I added a test for Thai line breaking this time
around. Also, I got around the failure on
fast/text/line-break-before-text-node.html by not running the new code if
-webkit-text-combine is present.

I know that the string manipulation in this patch is highly inefficient; help
would really be appreciated. [1] and [2] talk about creating UText objects from
discontinuous strings but it is not clear whether this feature is anything more
than theoretical. Any other information about how you want the solution to look
would also be helpful.

[1] http://userguide.icu-project.org/strings/utext
[2] http://icu-project.org/apiref/icu4c/utext_8h.html