[webkit-reviews] review granted: [Bug 97064] mathml.css: remove a few no-op lines : [Attachment 164650] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 18 20:33:25 PDT 2012


Eric Seidel <eric at webkit.org> has granted Dave Barton
<dbarton at mathscribe.com>'s request for review:
Bug 97064: mathml.css: remove a few no-op lines
https://bugs.webkit.org/show_bug.cgi?id=97064

Attachment 164650: Patch
https://bugs.webkit.org/attachment.cgi?id=164650&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=164650&action=review


Looks good.  Please answer the nits above before landing. :)

> Source/WebCore/css/mathml.css:-71
> -    padding-right: 0.1em;

Why doesn't this do anything?

> Source/WebCore/css/mathml.css:-84
> -mo, mn, mi, mtext {
> -    padding: 0px;
> -}

Is this trying to disabling padding for these elments?	Did the author intend
this to be !important?


More information about the webkit-reviews mailing list