[webkit-reviews] review canceled: [Bug 96742] Fix unused parameter compile warnings in WebKit/WebKit2 : [Attachment 164539] patch

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at samsung.com> has canceled Jinwoo Song
<jinwoo7.song at samsung.com>'s request for review:
Bug 96742: Fix unused parameter compile warnings in WebKit/WebKit2
https://bugs.webkit.org/show_bug.cgi?id=96742

Attachment 164539: patch
https://bugs.webkit.org/attachment.cgi?id=164539&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=164539&action=review


> Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:396
> +void ChromeClientEfl::reachedMaxAppCacheSize(int64_t)

/* spaceNeeded */ ?

> Source/WebKit/efl/ewk/ewk_frame.cpp:1828
> +WTF::PassRefPtr<WebCore::Widget> ewk_frame_plugin_create(Evas_Object*
ewkFrame, const WebCore::IntSize& pluginSize, WebCore::HTMLPlugInElement*
element, const WebCore::KURL& url, const WTF::Vector<WTF::String>& paramName,
const WTF::Vector<WTF::String>& paramValues, const WTF::String& mimeType, bool
loadManually)

I think paramNames is proper for Vector.

> Source/WebKit/efl/ewk/ewk_view.cpp:620
> +static void _ewk_view_smart_add_console_message(Ewk_View_Smart_Data*, const
char* message, unsigned lineNumber, const char* sourceID)

You should not change *unsigned int* to *unsigned* in this patch.

> Source/WebKit/efl/ewk/ewk_view.cpp:1040
> +static void _ewk_view_smart_move(Evas_Object* ewkView, Evas_Coord,
Evas_Coord)

Need to use /* */ for x, y.

> Source/WebKit/efl/ewk/ewk_view.cpp:4481
> +bool ewk_view_accelerated_compositing_object_create(Evas_Object*
/*ewkView*/, Evas_Native_Surface* /*nativeSurface*/, const WebCore::IntRect&
/*rect*/)

Unneeded to wrap /* */ to ewkView and nativeSurface.

> Source/WebKit/efl/ewk/ewk_view.cpp:4487
> +WebCore::GraphicsContext3D*
ewk_view_accelerated_compositing_context_get(Evas_Object* /*ewkView*/)

Unneeded /* */ because ewkView is clear in this file.

> Source/WebKit/efl/ewk/ewk_view_tiled.cpp:49
> +static void* _ewk_view_tiled_updates_process_pre(void* data, Evas_Object*
/*ewkView*/)

ditto.

> Source/WebKit/efl/ewk/ewk_view_tiled.cpp:66
> +_ewk_view_tiled_contents_size_changed_cb(void* data, Evas_Object*
/*ewkView*/, void* eventInfo)

ditto.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:292
> +static void _ewk_view_on_focus_out(void* data, Evas*, Evas_Object*
/*ewkView*/, void* /*eventInfo*/)

ditto.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:300
> +static void _ewk_view_on_mouse_wheel(void* data, Evas*, Evas_Object*
/*ewkView*/, void* eventInfo)

ditto.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:309
> +static void _ewk_view_on_mouse_down(void* data, Evas*, Evas_Object*
/*ewkView*/, void* eventInfo)

ditto.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:318
> +static void _ewk_view_on_mouse_up(void* data, Evas*, Evas_Object*
/*ewkView*/, void* eventInfo)

ditto.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:327
> +static void _ewk_view_on_mouse_move(void* data, Evas*, Evas_Object*
/*ewkView*/, void* eventInfo)

ditto.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:336
> +static void _ewk_view_on_key_down(void* data, Evas*, Evas_Object*
/*ewkView*/, void* eventInfo)

ditto.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:345
> +static void _ewk_view_on_key_up(void* data, Evas*, Evas_Object* /*ewkView*/,
void* eventInfo)

ditto.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:455
> +static void _ewk_view_smart_move(Evas_Object* ewkView, Evas_Coord,
Evas_Coord)

ditto.

> Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp:266
> +void WebChromeClient::addMessageToConsole(MessageSource, MessageType,
MessageLevel, const String& message, unsigned lineNumber, const String&
/*sourceID*/)

ditto.