[webkit-reviews] review granted: [Bug 96137] [chromium] Store the contents scale factor in PlatformContextSkia on initialization : [Attachment 164633] Patch

[bugzilla-daemon at webkit.org]

Stephen White <senorblanco at chromium.org> has granted Terry Anderson
<tdanderson at chromium.org>'s request for review:
Bug 96137: [chromium] Store the contents scale factor in PlatformContextSkia on
initialization
https://bugs.webkit.org/show_bug.cgi?id=96137

Attachment 164633: Patch
https://bugs.webkit.org/attachment.cgi?id=164633&action=review

------- Additional Comments from Stephen White <senorblanco at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=164633&action=review


Looks good.  r=me

>> Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp:192
>> +	, m_hintingScaleFactor(SK_Scalar1)
> 
> nit: Can this just be set to "1"?

For SkScalars, SK_Scalar1 is correct (just in case we decide to compile with
SK_SCALAR_IS_FIXED someday, for example).