[webkit-reviews] review granted: [Bug 97049] Replace RenderIFrame::updateLogicalHeight with RenderIFrame::computeLogicalHeight : [Attachment 164629] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 18 15:34:41 PDT 2012
Eric Seidel <eric at webkit.org> has granted Tony Chang <tony at chromium.org>'s
request for review:
Bug 97049: Replace RenderIFrame::updateLogicalHeight with
RenderIFrame::computeLogicalHeight
https://bugs.webkit.org/show_bug.cgi?id=97049
Attachment 164629: Patch
https://bugs.webkit.org/attachment.cgi?id=164629&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
LGTM. Do we (I?) need to add a test for changed behavior here? I'm sure I may
have gotten this function wrong in my initial implementation.
More information about the webkit-reviews
mailing list