[webkit-reviews] review denied: [Bug 97034] [WK2][WTR] Policy client: dumping from decidePolicyForResponse callback : [Attachment 164599] patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Mikhail Pozdnyakov
<mikhail.pozdnyakov at intel.com>'s request for review:
Bug 97034: [WK2][WTR] Policy client: dumping from decidePolicyForResponse
callback
https://bugs.webkit.org/show_bug.cgi?id=97034

Attachment 164599: patch
https://bugs.webkit.org/attachment.cgi?id=164599&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=164599&action=review


>> Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:1329
>> +	    const size_t position = disposition.find('=');
> 
> The suggested filename is already parsed in the resource response. I think it
would be nicer to add the corresponding C API in WKURLResponse to retrieve the
suggested file name from the response.

It's not necessarily just parsed - on some platforms, it is produced by code
outside WebKit.

Re-implementing WebCore code in WKTR is not what we should be doing to test
WebCore code. We are not testing it if we have a separate implementation in the
tester.