[webkit-reviews] review granted: [Bug 96910] waitUntilTitleChangedTo and waitUntilLoadFinished needs timeout. : [Attachment 164589] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Byungwoo Lee
<bw80.lee at samsung.com>'s request for review:
Bug 96910: waitUntilTitleChangedTo and waitUntilLoadFinished needs timeout.
https://bugs.webkit.org/show_bug.cgi?id=96910

Attachment 164589: Patch
https://bugs.webkit.org/attachment.cgi?id=164589&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=164589&action=review


> Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:115

> +
> +    if (data->timer) {
> +	   ecore_timer_del(data->timer);
> +	   data->timer = 0;
> +    }

Is the LoadFinishedData going to be reused? or is there any need for the above?
just wondering