[webkit-reviews] review granted: [Bug 95707] Add partial load tests for PNG images : [Attachment 162684] Patch for landing (honest)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 18 12:56:04 PDT 2012


Adam Barth <abarth at webkit.org> has granted noel gordon
<noel.gordon at gmail.com>'s request for review:
Bug 95707: Add partial load tests for PNG images
https://bugs.webkit.org/show_bug.cgi?id=95707

Attachment 162684: Patch for landing (honest)
https://bugs.webkit.org/attachment.cgi?id=162684&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=162684&action=review


> LayoutTests/http/tests/images/png-partial-load.html:4
> +    testRunner.dumpAsText(pixelTest = true);

You can remove the "pixelTest" variable here.  It doesn't seem to be used
anywhere.

> LayoutTests/http/tests/images/png-partial-load.html:20
> +    if (window.testRunner) testRunner.notifyDone();

two lines pls


More information about the webkit-reviews mailing list